=== Summary: 675 files | 7 generated | 484 fresh | 4605 untracked | 4268 adopted | 355 marked | 466 validated-ok | 2+0 stale (sig+body) | 0 skipped | 0 failed | elapsed 11:08:11.442 (40091.44s) ===

adas-core.Domain/Models/PatientTreatment.cs

@@ -13,6 +13,7 @@ namespace adas_core.Domain.Models;
 /// <remarks>
 /// This converter overrides the default JSON conversion behavior to control how <see cref="PatientTreatment"/> objects are written to and read from JSON.
 /// </remarks>
+/// <!-- aidoc:v1 sig=ce9ac9e -->
 public class PatientTreatment : JsonConverter
 {
     //If bolopom plus to bolus opiates.
@@ -86,6 +87,8 @@ public class PatientTreatment : JsonConverter
     /// Returns a string representation of the PatientTreatment instance, including its core identifiers, order details, timing fields, requested give codes, notes, and routes. Non-null or non-empty properties are appended to the output, and in case of an exception during formatting, an error message containing the exception detail is returned instead.
     /// </summary>
     /// <returns>A formatted string summarizing the PatientTreatment fields, or an error message if formatting fails.</returns>
+    /// <!-- aidoc-review:v1 severity=low kind=wrong_summary
+    ///      "The summary states 'Non-null or non-empty properties are appended to the output', but several properties (Id, PatientId, OrderControl, SingleDose, BoloPom, MessageTime) are always appended without a null/empty check." -->
     public override string ToString()
         {
             try
@@ -147,6 +150,8 @@ public class PatientTreatment : JsonConverter
     /// <param name="writer">The <see cref="JsonWriter"/> to which the JSON representation of the value will be written.</param>
     /// <param name="value">The object to serialize. If null, the method performs no action.</param>
     /// <param name="serializer">The <see cref="JsonSerializer"/> used to perform the serialization of nested objects.</param>
+    /// <!-- aidoc-review:v1 severity=medium kind=wrong_param_role
+    ///      "The `serializer` parameter is described as 'used to perform the serialization of nested objects', but the method body never references it (serialization is performed via JObject.FromObject(value) and jo.WriteTo(writer))." -->
     public override void WriteJson(JsonWriter writer, object? value, JsonSerializer serializer)
         {
             if (value != null)
@@ -165,6 +170,7 @@ public class PatientTreatment : JsonConverter
     /// </summary>
     /// <param name="value">The object instance whose property should receive the attribute.</param>
     /// <param name="propertyName">The name of the property to which the attribute will be added.</param>
+    /// <!-- aidoc:v1 sig=02b15d7 body=a196735 -->
     private static void AddStringEnumConverterAttribute(object value, string propertyName)
         {
             var prop = value.GetType().GetProperty(propertyName);
@@ -199,6 +205,8 @@ public class PatientTreatment : JsonConverter
     /// <param name="serializer">The <see cref="JsonSerializer"/> invoking this converter.</param>
     /// <returns>An object of the specified type deserialized from the JSON.</returns>
     /// <exception cref="NotImplementedException">Always thrown because the method has not been implemented.</exception>
+    /// <!-- aidoc-review:v1 severity=low kind=wrong_returns
+    ///      "The <returns> tag states the method returns 'An object of the specified type deserialized from the JSON', but the method unconditionally throws NotImplementedException and never returns a value. The summary and exception tag do clarify this, so the impact on readers is limited." -->
     public override object ReadJson(JsonReader reader, Type objectType, object? existingValue,
             JsonSerializer serializer)
         {
@@ -211,6 +219,10 @@ public class PatientTreatment : JsonConverter
     /// <param name="objectType">The type to check for conversion support.</param>
     /// <returns><see langword="true"/> if the converter can convert the specified type; otherwise, <see langword="false"/>.</returns>
     /// <exception cref="NotImplementedException">Always thrown because the method is not yet implemented.</exception>
+    /// <!-- aidoc-review:v1 severity=high kind=wrong_returns
+    ///      "The method always throws NotImplementedException and never returns a boolean value, so the documented return contract (true/false) is inaccurate." -->
+    /// <!-- aidoc-review:v1 severity=high kind=stale_summary
+    ///      "The summary states the method 'determines whether the converter can convert the specified type', but the implementation does not perform any determination; it unconditionally throws." -->
     public override bool CanConvert(Type objectType)
         {
             throw new NotImplementedException();