docs(iec62304): [REL-1.0.2] apply curated XML doc review updates

docs(iec62304): [REL-1.0.2] validate and curate XML doc review markers
Conflicto de fusión en adas-core.LdapLogin/LdapLoginService.cs
2026-07-06 21:21:05 +02:00 · 2026-07-06 21:15:15 +02:00 · 2026-07-06 19:33:59 +02:00 · 2026-07-06 19:30:28 +02:00
15 changed files with 309 additions and 304 deletions
@@ -21,23 +21,20 @@

        <PackageReference Include="AutoMapper" Version="16.1.1" />

-        <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Scripting" Version="5.3.0" />
+        <PackageReference Include="Microsoft.AspNetCore.Http" Version="2.3.11" />

-        <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="10.0.8" />
-        <PackageReference Include="Microsoft.Extensions.Http" Version="10.0.8" />
-        <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.8" />
-        <PackageReference Include="Microsoft.Extensions.Options" Version="10.0.8" />
-        <PackageReference Include="Microsoft.IdentityModel.JsonWebTokens" Version="8.18.0" />
+        <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="5.3.0">
+          <PrivateAssets>all</PrivateAssets>
+          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
+
+        <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Scripting" Version="5.3.0" />
+        <PackageReference Include="Microsoft.Extensions.Http" Version="10.0.9" />
+        <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.9" />
+        <PackageReference Include="Microsoft.Extensions.Options" Version="10.0.9" />
        <PackageReference Include="MongoDB.Driver" Version="3.9.0" />
        <PackageReference Include="Quartz" Version="3.18.1" />
-        <PackageReference Include="StackExchange.Redis" Version="2.13.17" />
-        <PackageReference Include="System.Text.Json" Version="10.0.8" />
-    </ItemGroup>
-
-    <ItemGroup>
-        <Reference Include="Microsoft.AspNetCore.Http.Features">
-            <HintPath>..\..\..\..\..\..\..\Program Files\dotnet\shared\Microsoft.AspNetCore.App\7.0.10\Microsoft.AspNetCore.Http.Features.dll</HintPath>
-        </Reference>
+        <PackageReference Include="StackExchange.Redis" Version="3.0.0" />
    </ItemGroup>

 </Project>
@@ -9,12 +9,17 @@

    <ItemGroup>
        <PackageReference Include="AuditLogs" Version="1.0.59" />
-        <PackageReference Include="Microsoft.AspNetCore.Http" Version="2.3.10" />
-        <PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="8.0.27" />
-        <PackageReference Include="Microsoft.Extensions.Configuration" Version="10.0.8" />
-        <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="10.0.8" />
-        <PackageReference Include="Microsoft.IdentityModel.Tokens" Version="8.18.0" />
-        <PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="8.18.0" />
+        <PackageReference Include="Microsoft.AspNetCore.Http" Version="2.3.11" />
+        <PackageReference Include="Microsoft.AspNetCore.Mvc.Abstractions" Version="2.3.11" />
+        <PackageReference Include="Microsoft.AspNetCore.Mvc.Core" Version="2.3.11" />
+        <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="5.3.0">
+          <PrivateAssets>all</PrivateAssets>
+          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
+        <PackageReference Include="Microsoft.Extensions.Configuration" Version="10.0.9" />
+        <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="10.0.9" />
+        <PackageReference Include="Microsoft.IdentityModel.Tokens" Version="8.19.1" />
+        <PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="8.19.1" />
    </ItemGroup>

    <ItemGroup>
@@ -10,17 +10,13 @@
    <ItemGroup>
        <PackageReference Include="AuditLogs" Version="1.0.59" />
        <PackageReference Include="BCrypt.Net-Next" Version="4.2.0" />
-        <PackageReference Include="Microsoft.AspNetCore.Mvc.Abstractions" Version="2.3.10" />
-        <PackageReference Include="Microsoft.AspNetCore.Mvc.Core" Version="2.3.10" />
-        <PackageReference Include="Microsoft.EntityFrameworkCore" Version="8.0.27" />
+        <PackageReference Include="Microsoft.EntityFrameworkCore" Version="8.0.28" />
        <PackageReference Include="MongoDB.Bson" Version="3.9.0" />
        <PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
        <PackageReference Include="Newtonsoft.Json.Bson" Version="1.0.3" />
        <PackageReference Include="Serilog" Version="4.3.1" />
-        <PackageReference Include="SharpCompress" Version="0.49.0" />
-        <PackageReference Include="Snappier" Version="1.3.1" />
-        <PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="8.18.0" />
-        <PackageReference Include="System.Text.Json" Version="10.0.8" />
+        <PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="8.19.1" />
+        <PackageReference Include="System.Text.Json" Version="10.0.9" />
        <PackageReference Include="TagLibSharp" Version="2.3.0" />
    </ItemGroup>

@@ -20,6 +20,7 @@ namespace adas_core.Infrastructure.Repositories;
 /// options lists, diagnoses, allergies, procedures, treatments, and other reference data.
 /// </summary>
 /// <typeparam name="T">The type of MasterList entity to manage.</typeparam>
+/// <!-- aidoc:v1 sig=f958de2 -->
 public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository<T> where T : MasterList
 {
    private readonly ApiSettings _apiSettings;
@@ -30,6 +31,7 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    /// <param name="apiSettings">API settings containing collection names configuration.</param>
    /// <param name="database">The MongoDB database instance.</param>
    /// <exception cref="ArgumentNullException">Thrown when apiSettings is null.</exception>
+    /// <!-- aidoc:v1 sig=800d538 body=d2b18a3 -->
    public MasterListRepository(IOptions<ApiSettings> apiSettings, IMongoDatabase database) : base(database)
    {
        if (apiSettings == null) throw new ArgumentNullException(nameof(apiSettings));
@@ -41,6 +43,7 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    /// Maps different MasterList subtypes to their corresponding MongoDB collection names.
    /// </summary>
    /// <returns>The collection name for the current MasterList type.</returns>
+    /// <!-- aidoc:v1 sig=94e22ff body=64e6c55 -->
    public override string GetCollectionName()
    {
        return typeof(T) switch
@@ -94,6 +97,7 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    /// </summary>
    /// <param name="id">The ObjectId of the entity to delete.</param>
    /// <exception cref="Exception">Throws and re-throws exceptions after logging.</exception>
+    /// <!-- aidoc:v1 sig=3de1ad6 body=fe0ba8c -->
    public async Task Delete(ObjectId id)
    {
        try
@@ -109,10 +113,11 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Updates an existing master list entity with full replacement.
+    /// Persists the supplied <typeparamref name="T"/> entity in the collection by replacing the document identified by <see cref="T.Id"/>, or inserting a new document when no match is found (upsert). Logs and rethrows any exception raised during the operation.
    /// </summary>
-    /// <param name="entity">The entity with updated values.</param>
-    /// <exception cref="Exception">Throws and re-throws exceptions after logging.</exception>
+    /// <typeparam name="T">The document type stored in the collection.</typeparam>
+    /// <param name="entity">The entity whose <see cref="T.Id"/> locates the target document and whose state is written to the collection.</param>
+    /// <!-- aidoc:v1 sig=019b691 body=863650a -->
    public async Task Update(T entity)
    {
        try
@@ -133,6 +138,7 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    /// <param name="id">The ObjectId of the master list.</param>
    /// <param name="newOpt">The OptionList with updated values.</param>
    /// <returns>The updated OptionList if found; otherwise, null.</returns>
+    /// <!-- aidoc:v1 sig=64ca4dd body=a7714e6 -->
    public async Task<OptionList?> UpdateFullMasterListOption(ObjectId id, OptionList newOpt)
    {
        var filter = Builders<T>.Filter.Where(o => o.Id == id && o.Options.Any(opt => opt.Id == newOpt.Id)
@@ -161,11 +167,12 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Finds a master list entity by its ID with options projection limited to 100 items.
+    /// Asynchronously retrieves an entity of type <typeparamref name="T"/> from the collection by its <see cref="ObjectId"/>, applying a projection that truncates the <c>options</c> field to 100 elements. Returns <see langword="null"/> when no matching document is found, or when an exception is caught and logged by <see cref="Log"/>.
    /// </summary>
-    /// <param name="id">The ObjectId of the entity to retrieve.</param>
-    /// <returns>The MasterList entity if found; otherwise, null.</returns>
-    /// <exception cref="Exception">Logs errors and returns null on failure.</exception>
+    /// <typeparam name="T">The document type stored in the collection, expected to expose an <see cref="ObjectId"/> identifier.</typeparam>
+    /// <param name="id">The <see cref="ObjectId"/> of the entity to locate.</param>
+    /// <returns>A <see cref="Task{T}"/> that resolves to the matching entity, or <see langword="null"/> if the document is not found or the operation fails.</returns>
+    /// <!-- aidoc:v1 sig=81ac96a body=1519944 -->
    public async Task<T?> FindById(ObjectId id)
    {
        try
@@ -189,14 +196,13 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Finds a specific option within a master list by master and option IDs with locale translation.
-    /// Uses MongoDB aggregation to apply translations and return the translated option.
+    /// Retrieves a single <see cref="OptionList"/> item from a master document identified by <paramref name="masterId"/> and <paramref name="optionId"/>, applying locale-aware name resolution. When <paramref name="locale"/> is <see cref="LocaleEnum.Default"/> or matches the document's default locale, the base name is returned; otherwise, the matching entry from the <c>localeItems</c> map is used, falling back to the base name when no translation is found. Returns <see langword="null"/> when the option is not found or if an error occurs during aggregation.
    /// </summary>
-    /// <param name="masterId">The ObjectId of the master list.</param>
-    /// <param name="optionId">The ObjectId of the option to retrieve.</param>
-    /// <param name="locale">The locale for translation.</param>
-    /// <returns>The OptionList with translated fields if found; otherwise, null.</returns>
-    /// <exception cref="Exception">Logs errors and returns null on failure.</exception>
+    /// <param name="masterId">The <see cref="ObjectId"/> of the master document that contains the option collection to search.</param>
+    /// <param name="optionId">The <see cref="ObjectId"/> of the specific option within the master document's options array.</param>
+    /// <param name="locale">The <see cref="LocaleEnum"/> value that drives translation selection; <see cref="LocaleEnum.Default"/> resolves to the document's default locale, while any other value attempts a locale-specific lookup.</param>
+    /// <returns>A <see cref="Task{TResult}"/> that yields the matched <see cref="OptionList"/>, or <see langword="null"/> if no document/option is found or the operation fails.</returns>
+    /// <!-- aidoc:v1 sig=fdb2628 body=0e4983e -->
    public async Task<OptionList?> FindOptionItemById(ObjectId masterId, ObjectId optionId, LocaleEnum locale)
    {
        try
@@ -342,6 +348,7 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    /// <param name="optionId">The ObjectId of the option to retrieve.</param>
    /// <returns>The OptionList if found; otherwise, null.</returns>
    /// <exception cref="Exception">Logs errors and returns null on failure.</exception>
+    /// <!-- aidoc:v1 sig=ccc34cb body=71837cc -->
    public async Task<OptionList?> FindOptionItemById(ObjectId masterId, ObjectId optionId)
    {
        try
@@ -367,13 +374,12 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Finds a master list entity by its ID with optional locale translation for options.
-    /// Uses MongoDB aggregation to unwind options and apply translations.
+    /// Asynchronously finds an entity of type <typeparamref name="T"/> by its MongoDB <see cref="ObjectId"/>, executing an aggregation pipeline that unwinds the <c>options</c> array and resolves localized option names. When <paramref name="locale"/> is <c>null</c> or <see cref="LocaleEnum.Default"/>, the original option name is returned; otherwise, the option name is translated using the supplied locale, falling back to the original name when no matching <c>localeItems</c> entry exists. Returns <c>null</c> when no document is found or when an exception is caught and logged.
    /// </summary>
-    /// <param name="id">The ObjectId of the entity to retrieve.</param>
-    /// <param name="locale">Optional locale for translated option names.</param>
-    /// <returns>The MasterList entity with translated options if found; otherwise, null.</returns>
-    /// <exception cref="Exception">Logs errors and returns null on failure.</exception>
+    /// <param name="id">The MongoDB <see cref="ObjectId"/> that uniquely identifies the document to retrieve.</param>
+    /// <param name="locale">The optional <see cref="LocaleEnum"/> used to resolve translated option names; pass <c>null</c> or <see cref="LocaleEnum.Default"/> to use the default (non-translated) names.</param>
+    /// <returns>A <see cref="Task{T}"/> that yields the matched entity of type <typeparamref name="T"/>, or <c>null</c> if no document matches <paramref name="id"/> or if an error occurs during aggregation.</returns>
+    /// <!-- aidoc:v1 sig=cb4a658 body=f2e88d8 -->
    public async Task<T?> FindById(ObjectId id, LocaleEnum? locale)
    {
        try
@@ -551,11 +557,11 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Finds a master list entity by its name.
+    /// Asynchronously finds a single <typeparamref name="T"/> entity by its <see cref="T.Name"/> using a MongoDB query, projecting only the first 100 elements of the <c>options</c> field to limit payload size. Returns <c>null</c> if no matching document is found or if an error occurs during the search.
    /// </summary>
-    /// <param name="name">The name of the master list to retrieve.</param>
-    /// <returns>The MasterList entity if found; otherwise, null.</returns>
-    /// <exception cref="Exception">Logs errors and returns null on failure.</exception>
+    /// <param name="name">The name value used to build the equality filter against the entity's <c>Name</c> field.</param>
+    /// <returns>A <see cref="Task{T}"/> that yields the matching <typeparamref name="T"/> instance, or <c>null</c> when no document matches or the operation fails.</returns>
+    /// <!-- aidoc:v1 sig=80a1541 body=8b5b558 -->
    public async Task<T?> FindByName(string name)
    {
        try
@@ -584,6 +590,7 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    /// <param name="id">The ObjectId of the master list.</param>
    /// <param name="textSearch">Optional text to search within options.</param>
    /// <returns>A list of matching OptionList items.</returns>
+    /// <!-- aidoc:v1 sig=569d223 body=bb7f2c6 -->
    public async Task<List<OptionList>> GetMasterListByIdAndTextSearchContaining(ObjectId id, string? textSearch)
    {
        return await GetOptionsByTextSearch(textSearch, id);
@@ -594,6 +601,7 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    /// </summary>
    /// <param name="filter">The pagination and filtering parameters.</param>
    /// <returns>A fluent queryable for MasterList results.</returns>
+    /// <!-- aidoc:v1 sig=bbb39c7 body=f42ebaa -->
    public IFindFluent<T, T> GetPaginatedMasterList(PaginationFilter filter)
    {
        var filterBuilder = Builders<T>.Filter;
@@ -616,11 +624,12 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Retrieves paginated options within a master list with optional text filtering.
+    /// Retrieves the options belonging to the master list identified by <paramref name="listId"/>, optionally narrowed down by the text contained in <paramref name="filter"/>. Returns an empty collection when no master list exists for the given identifier, and when a non-empty filter text is supplied, applies a case-insensitive match against each option's name, description, or option type.
    /// </summary>
-    /// <param name="filter">The pagination and filtering parameters.</param>
-    /// <param name="listId">The ObjectId of the master list.</param>
-    /// <returns>A list of filtered OptionList items.</returns>
+    /// <param name="filter">The <see cref="PaginationFilter"/> that provides the optional text used to filter the returned options.</param>
+    /// <param name="listId">The <see cref="ObjectId"/> of the master list whose options should be retrieved.</param>
+    /// <returns>A <see cref="Task"/> that resolves to a <see cref="List{OptionList}"/> of options matching the filter, or an empty list when the master list cannot be found.</returns>
+    /// <!-- aidoc:v1 sig=2ac8d75 body=b25fb18 -->
    public async Task<List<OptionList>> GetPaginatedOptions(PaginationFilter filter, ObjectId listId)
    {
        //TODO: LOCALE
@@ -640,12 +649,12 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Adds a new option to a master list.
+    /// Adds a new <see cref="OptionList"/> entry to the master list identified by <paramref name="id"/>. Returns the created option on success, or <c>null</c> if a matching option already exists, the master list cannot be retrieved, the update does not modify any document, or the operation throws an exception that is logged.
    /// </summary>
-    /// <param name="id">The ObjectId of the master list.</param>
-    /// <param name="opt">The option element to add.</param>
-    /// <returns>The newly created OptionList if successful; otherwise, null if duplicate exists.</returns>
-    /// <exception cref="Exception">Logs errors and returns null on failure.</exception>
+    /// <param name="id">The <see cref="ObjectId"/> of the master list to update.</param>
+    /// <param name="opt">The <see cref="FilterOptionListElement"/> describing the option to add; its locale items are reused when <see cref="FilterOptionListElement.IsFromAdmPanel"/> is <c>true</c>, otherwise new locale entries are generated from the master list's <see cref="LocaleEnum"/> default.</param>
+    /// <returns>A <see cref="Task{OptionList}"/> that resolves to the newly created <see cref="OptionList"/> when the push update succeeds, or <c>null</c> when the operation is skipped, no document is modified, or the update fails.</returns>
+    /// <!-- aidoc:v1 sig=1602f0d body=e7fd138 -->
    public async Task<OptionList?> AddOptionToMasterList(ObjectId id, FilterOptionListElement opt)
    {
        var exist = await GetMasterListByIdAndSearchOptions(id, opt);
@@ -685,10 +694,11 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Retrieves all master list entities.
+    /// Asynchronously retrieves all entities from the underlying collection.
+    /// If an exception occurs during retrieval, the error is logged and an empty collection is returned rather than propagating the failure.
    /// </summary>
-    /// <returns>An enumerable of all MasterList entities.</returns>
-    /// <exception cref="Exception">Logs errors and returns empty list on failure.</exception>
+    /// <returns>A <see cref="Task"/> that yields an <see cref="IEnumerable{T}"/> containing all retrieved entities, or an empty collection if the operation fails.</returns>
+    /// <!-- aidoc:v1 sig=3a61c61 body=40d7129 -->
    public async Task<IEnumerable<T>> GetAll()
    {
        try
@@ -704,10 +714,10 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Retrieves all master list entities without options, returning only metadata.
+    /// Retrieves all master list entries from the underlying collection without applying any filter and projects each result into a <see cref="MasterListDto"/>, where the <see cref="MasterListDto.Options"/> property is set to the count of associated options rather than the option list itself.
    /// </summary>
-    /// <returns>An enumerable of MasterListDto containing id, name, description, listType, and options count.</returns>
-    /// <exception cref="Exception">Logs errors and returns empty list on failure.</exception>
+    /// <returns>A <see cref="Task"/> that resolves to an <see cref="IEnumerable{T}"/> containing the projected <see cref="MasterListDto"/> instances, or an empty collection if an error is encountered while querying the data store.</returns>
+    /// <!-- aidoc:v1 sig=e493435 body=1c299ba -->
    public async Task<IEnumerable<MasterListDto>> GetAllWithoutOptions()
    {
        try
@@ -732,10 +742,13 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Counts the total number of master list entities in the collection.
+    /// Asynchronously counts all entities in the underlying <see cref="Collection"/> by invoking
+    /// <c>CountDocumentsAsync</c> with a filter that matches every document. If the operation fails,
+    /// the exception is logged via <c>Log.Error</c> and the method returns <c>0</c> as a safe fallback.
    /// </summary>
-    /// <returns>The total count of entities.</returns>
-    /// <exception cref="Exception">Logs errors and returns 0 on failure.</exception>
+    /// <returns>A <see cref="Task{Int32}"/> that represents the asynchronous count operation. The result
+    /// is the total number of entities, or <c>0</c> if an error occurred while querying the collection.</returns>
+    /// <!-- aidoc:v1 sig=f1f0a98 body=01cd3d1 -->
    public async Task<int> Count()
    {
        try
@@ -751,13 +764,12 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Searches for options within a master list using multiple filter criteria.
-    /// Uses MongoDB aggregation pipeline to apply filters and locale translations.
+    /// Retrieves the options of a master list identified by <paramref name="id"/>, applying the optional <paramref name="filters"/> to restrict the results by option type, text, name, or description, and resolving the localized <c>name</c> and <c>description</c> fields for each option based on the requested locale. When <paramref name="filters"/> is <c>null</c>, no options are returned. Text searches are performed case-insensitively against both the name and description of each option using a normalized pattern, and the final result is ordered alphabetically by name. Any exception during execution is logged and an empty list is returned.
    /// </summary>
-    /// <param name="id">The ObjectId of the master list.</param>
-    /// <param name="filters">The filter criteria including text, name, description, and optionType.</param>
-    /// <returns>A list of matching OptionList items ordered by name.</returns>
-    /// <exception cref="Exception">Logs errors and returns empty list on failure.</exception>
+    /// <param name="id">The <see cref="ObjectId"/> of the master list whose options will be queried.</param>
+    /// <param name="filters">Optional <see cref="FilterOptionListElement"/> containing the search criteria (option type, text, name, description, and locale). When <c>null</c>, the method returns an empty list.</param>
+    /// <returns>A <see cref="Task{List{OptionList}}"/> containing the filtered, localized, and alphabetically ordered options; an empty list is returned when no filters are provided, no options match, or an error occurs.</returns>
+    /// <!-- aidoc:v1 sig=f6ee5be body=17d6a96 -->
    public async Task<List<OptionList>> GetMasterListByIdAndSearchOptions(ObjectId id, FilterOptionListElement? filters)
    {
        try
@@ -966,13 +978,13 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Updates a specific option within a master list with locale-aware field updates.
+    /// Updates an option within a master list, handling duplicate detection, locale-specific translations, and conditional field updates based on the master list's required field rules.
    /// </summary>
-    /// <param name="id">The ObjectId of the master list.</param>
-    /// <param name="newOpt">The OptionList with updated values.</param>
-    /// <param name="locale">The locale for translation updates.</param>
-    /// <returns>The updated OptionList if successful; otherwise, null.</returns>
-    /// <exception cref="Exception">Logs errors and returns null on failure.</exception>
+    /// <param name="id">The <see cref="MongoDB.Bson.ObjectId"/> of the master list that contains the option to update.</param>
+    /// <param name="newOpt">The <see cref="OptionList"/> containing the new values to apply to the existing option.</param>
+    /// <param name="locale">The <see cref="LocaleEnum"/> indicating which locale the <paramref name="newOpt"/> applies to; when it matches the master's default locale, the main field is updated, otherwise the translation stored in <c>localeItems</c> is updated.</param>
+    /// <returns>A <see cref="Task{T}"/> containing the updated <see cref="OptionList"/>, the existing option when a duplicate is detected, or <c>null</c> when the option is not found, no fields qualify for update, or the update operation fails.</returns>
+    /// <!-- aidoc:v1 sig=e771f23 body=5520a4a -->
    public async Task<OptionList?> UpdateMasterListOption(ObjectId id, OptionList newOpt, LocaleEnum locale)
    {
        // 1. Evitar duplicados
@@ -1067,12 +1079,12 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Updates a specific option within a master list with full replacement.
+    /// Updates an existing option inside the master list identified by <paramref name="id"/> with the data from <paramref name="newOpt"/>. Returns <see langword="null"/> when the master list is not found, when no document is modified, or when an exception is caught and logged.
    /// </summary>
-    /// <param name="id">The ObjectId of the master list.</param>
-    /// <param name="newOpt">The OptionList with updated values.</param>
-    /// <returns>The updated OptionList if successful; otherwise, null.</returns>
-    /// <exception cref="Exception">Logs errors and returns null on failure.</exception>
+    /// <param name="id">The <see cref="ObjectId"/> of the master list that owns the option to update.</param>
+    /// <param name="newOpt">The <see cref="OptionList"/> whose <see cref="ObjectId"/> targets the option to replace and whose values are persisted to the document.</param>
+    /// <returns>A task containing the updated <see cref="OptionList"/> when the update succeeds, or <see langword="null"/> when the master list is missing, nothing was modified, or the update failed.</returns>
+    /// <!-- aidoc:v1 sig=6def54c body=9554543 -->
    public async Task<OptionList?> UpdateMasterListOption(ObjectId id, OptionList newOpt)
    {
        var master = await FindById(id);
@@ -1108,6 +1120,7 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    /// <param name="id">The ObjectId of the master list.</param>
    /// <param name="deleteOptId">The ObjectId of the option to delete.</param>
    /// <returns>True if the option was deleted; otherwise, false.</returns>
+    /// <!-- aidoc:v1 sig=e663f16 body=75627bc -->
    public async Task<bool> DeleteMasterListOption(ObjectId id, ObjectId deleteOptId)
    {
        // Define el filtro para encontrar el documento por su _id
@@ -1126,12 +1139,12 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Updates the metadata details for a master list.
+    /// Updates the option details of a master list document identified by <paramref name="id"/>, persisting only the non-null fields supplied in <paramref name="opt"/>.
    /// </summary>
-    /// <param name="id">The ObjectId of the master list.</param>
-    /// <param name="opt">The UpdateMasterListDetailsDto with updated values.</param>
-    /// <returns>The updated UpdateMasterListDetailsDto if successful; otherwise, null.</returns>
-    /// <exception cref="Exception">Logs errors and returns null on failure.</exception>
+    /// <param name="id">The <see cref="ObjectId"/> of the master list entry to update.</param>
+    /// <param name="opt">The <see cref="UpdateMasterListDetailsDto"/> whose non-null <see cref="UpdateMasterListDetailsDto.CanAddElement"/> and <see cref="UpdateMasterListDetailsDto.OptionListDetails"/> values are written to the document.</param>
+    /// <returns>The supplied <see cref="UpdateMasterListDetailsDto"/> when at least one field is modified, or <see langword="null"/> when the document is not found, no changes are applied, or the operation fails.</returns>
+    /// <!-- aidoc:v1 sig=53d4179 body=49f50ca -->
    public async Task<UpdateMasterListDetailsDto?> UpdateOptionDetailsToMasterList(ObjectId id,
        UpdateMasterListDetailsDto opt)
    {
@@ -1161,12 +1174,13 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Updates the name of a master list.
+    /// Updates the name of the master list document identified by <paramref name="id"/>.
+    /// Returns <c>true</c> if a document was modified, <c>false</c> if no document matched the id or if an exception was caught and logged.
    /// </summary>
-    /// <param name="id">The ObjectId of the master list.</param>
-    /// <param name="name">The new name.</param>
-    /// <returns>True if the update was successful; otherwise, false.</returns>
-    /// <exception cref="Exception">Logs errors and returns false on failure.</exception>
+    /// <param name="id">The <see cref="MongoDB.Bson.ObjectId"/> of the master list entry to update.</param>
+    /// <param name="name">The new name to assign to the entry.</param>
+    /// <returns>A <see cref="Task{Boolean}"/> that resolves to <c>true</c> when the update modified a document; otherwise, <c>false</c>.</returns>
+    /// <!-- aidoc:v1 sig=5b79a51 body=36dfe99 -->
    public async Task<bool> UpdateMasterListName(ObjectId id, string name)
    {
        var filter = Builders<T>.Filter.And(
@@ -1187,12 +1201,13 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Updates the description of a master list.
+    /// Updates the <see cref="T.Description"/> field of the master list entry identified by <paramref name="id"/>.
+    /// Returns <c>true</c> when the matched document is modified, and <c>false</c> when no document matches the filter or the underlying update operation throws, in which case the exception is logged and the call resolves to <c>false</c>.
    /// </summary>
-    /// <param name="id">The ObjectId of the master list.</param>
-    /// <param name="description">The new description.</param>
-    /// <returns>True if the update was successful; otherwise, false.</returns>
-    /// <exception cref="Exception">Logs errors and returns false on failure.</exception>
+    /// <param name="id">The <see cref="ObjectId"/> of the master list entry to update.</param>
+    /// <param name="description">The new description value to set on the entry.</param>
+    /// <returns>A <see cref="Task{Boolean}"/> that yields <c>true</c> if the update modified a document; otherwise, <c>false</c>.</returns>
+    /// <!-- aidoc:v1 sig=5a27a55 body=3552f46 -->
    public async Task<bool> UpdateMasterListDescription(ObjectId id, string description)
    {
        var filter = Builders<T>.Filter.And(
@@ -1219,6 +1234,7 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    /// <param name="oldOpt">The OptionList to remove.</param>
    /// <returns>True if the option was removed; otherwise, false.</returns>
    /// <exception cref="Exception">Logs errors and returns false on failure.</exception>
+    /// <!-- aidoc:v1 sig=8de50cd body=d974b9b -->
    public async Task<bool> RemoveMasterListOption(ObjectId id, OptionList oldOpt)
    {
        var filter = Builders<T>.Filter.Eq("_id", id);
@@ -1247,9 +1263,12 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Creates necessary indexes for the MasterList collection.
-    /// Currently creates text indexes for DiagnosisList on options.name, options.description, and options._id.
+    /// Creates background MongoDB indexes on the <see cref="DiagnosisList"/> collection to optimize queries against the nested <c>options</c> document fields, configuring the indexes with <c>spanish</c> as both the default and override language for text indexing.
    /// </summary>
+    /// <remarks>
+    /// When the generic type parameter is not <see cref="DiagnosisList"/>, the method performs no actions and returns without creating any indexes.
+    /// </remarks>
+    /// <!-- aidoc:v1 sig=4955da2 body=2c8d1f7 -->
    public override async Task CreateIndexes()
    {
        if (typeof(T) == typeof(DiagnosisList))
@@ -1275,6 +1294,7 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    /// </summary>
    /// <param name="textSearch">Optional text to search within options.</param>
    /// <returns>A list of matching OptionList items.</returns>
+    /// <!-- aidoc:v1 sig=484b092 body=48e3496 -->
    public async Task<List<OptionList>> GetMasterListByTextSearch(string? textSearch)
    {
        return await GetOptionsByTextSearch(textSearch);
@@ -1287,6 +1307,7 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    /// <param name="id">Optional master list ObjectId to filter results.</param>
    /// <returns>A list of matching OptionList items ordered by name.</returns>
    /// <exception cref="Exception">Logs errors and returns empty list on failure.</exception>
+    /// <!-- aidoc:v1 sig=6ebeac8 body=1d7bbb7 -->
    private async Task<List<OptionList>> GetOptionsByTextSearch(string? textSearch, ObjectId? id = null)
    {
        try
@@ -1296,7 +1317,6 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository

            // Normaliza el texto de búsqueda a minúsculas
            var normalizedTextSearch = textSearch.ToLowerInvariant();
-            // Construye la expresión regular dinámica para tener en cuenta la acentuación en las vocales
            var regexPattern = BuildRegexPattern(normalizedTextSearch);
            // foreach (var c in normalizedTextSearch)
            // {
@@ -1360,11 +1380,12 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Creates a fluent query for paginated results with combined filters.
+    /// Creates a find query against the underlying collection by combining the provided <paramref name="filters"/> with a logical AND and applying the specified <paramref name="sort"/>. When the filter list is empty, an empty filter is used so that the query matches every document.
    /// </summary>
-    /// <param name="filters">List of filter definitions to apply.</param>
-    /// <param name="sort">Sort definition for the query results.</param>
-    /// <returns>A fluent queryable for T results.</returns>
+    /// <param name="filters">The list of <see cref="FilterDefinition{T}"/> predicates to combine; an empty list causes no filtering to be applied.</param>
+    /// <param name="sort">The <see cref="SortDefinition{T}"/> used to order the returned documents.</param>
+    /// <returns>An <see cref="IFindFluent{T,T}"/> configured with the combined filter and sort, ready for further chaining.</returns>
+    /// <!-- aidoc:v1 sig=704d715 body=2a35652 -->
    private IFindFluent<T, T> CreateFindFluent(List<FilterDefinition<T>> filters, SortDefinition<T> sort)
    {
        var combinedFilter = filters.Any()
@@ -1380,6 +1401,7 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    /// <param name="localeList">The default locale to exclude from translations.</param>
    /// <param name="opt">The option name to use as default translation.</param>
    /// <returns>A Locale object with translations for all other locales.</returns>
+    /// <!-- aidoc:v1 sig=147db59 body=9b63847 -->
    private Locale GetNewItemLocale(LocaleEnum localeList, string opt)
    {
        var newLocale = new Locale();
@@ -1419,6 +1441,7 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    /// </summary>
    /// <param name="input">The input string to build the pattern from.</param>
    /// <returns>A regex-compatible pattern string.</returns>
+    /// <!-- aidoc:v1 sig=2992c00 body=ae88daf -->
    private static string BuildRegexPattern(string input)
    {
        var regexPattern = new StringBuilder();
@@ -1452,14 +1475,13 @@ public class MasterListRepository<T> : MongoRepository<T>, IMasterListRepository
    }

    /// <summary>
-    /// Searches for options within a master list by name with locale translation.
-    /// Uses MongoDB aggregation pipeline to apply locale-aware filtering.
+    /// Asynchronously retrieves a filtered list of <see cref="OptionList"/> entries from the master collection by matching the document with the specified <paramref name="id"/> and filtering options whose resolved name equals <paramref name="newOptName"/> for the given <paramref name="locale"/>. When the requested locale differs from the document's default, the pipeline uses the translated name from <c>localeItems</c>, falling back to the original name if no translation is available. Returns an empty list if no matching options are found or if an exception is logged during execution.
    /// </summary>
-    /// <param name="id">The ObjectId of the master list.</param>
-    /// <param name="newOptName">The option name to search for.</param>
-    /// <param name="locale">The locale for translation.</param>
-    /// <returns>A list of matching OptionList items ordered by name.</returns>
-    /// <exception cref="Exception">Logs errors and returns empty list on failure.</exception>
+    /// <param name="id">The <see cref="ObjectId"/> identifying the master document to aggregate.</param>
+    /// <param name="newOptName">The option name used to filter the options after locale-based name resolution.</param>
+    /// <param name="locale">The <see cref="LocaleEnum"/> value used to select the translated name for each option.</param>
+    /// <returns>A <see cref="Task"/> containing a <see cref="List{T}"/> of <see cref="OptionList"/> entries ordered by name, or an empty list when no match exists or an error is caught.</returns>
+    /// <!-- aidoc:v1 sig=342dc63 body=21f31fc -->
    private async Task<List<OptionList>> GetMasterListByIdAndTextSearch(
        ObjectId id, string newOptName, LocaleEnum locale)
    {
@@ -9,11 +9,14 @@

    <ItemGroup>
        <PackageReference Include="AuditLogs" Version="1.0.59" />
-        <PackageReference Include="EasyNetQ" Version="8.1.4" />
-        <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="10.0.8" />
-        <PackageReference Include="Microsoft.Extensions.Options" Version="10.0.8" />
+		<PackageReference Include="EasyNetQ" Version="8.1.5" />
+        <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="5.3.0">
+          <PrivateAssets>all</PrivateAssets>
+          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
+        <PackageReference Include="Microsoft.Extensions.Options" Version="10.0.9" />
        <PackageReference Include="MongoMigrations.Core" Version="4.0.15" />
-        <PackageReference Include="StackExchange.Redis" Version="2.13.17" />
+        <PackageReference Include="StackExchange.Redis" Version="3.0.0" />
    </ItemGroup>

    <ItemGroup>
@@ -5,11 +5,12 @@ using adas_core.Domain.Models.MongoModels;
 using adas_core.LdapLogin.Configuration;
 using FluentValidation;
 using Microsoft.AspNetCore.Http;
-using Microsoft.AspNetCore.Http.HttpResults;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
 using MongoDB.Bson;
-using Novell.Directory.Ldap;
+using System.DirectoryServices.Protocols;
+using System.Net;
+using Authorization = adas_core.Domain.Models.MongoModels.Authorization;

 namespace adas_core.LdapLogin;

@@ -19,6 +20,7 @@ namespace adas_core.LdapLogin;
 /// The service also handles the creation of new users in the application if they do not already exist, based on the LDAP information. 
 /// It uses configuration settings for connecting to the LDAP server and for mapping LDAP attributes to user properties and authorities.
 /// </summary>
+/// <!-- aidoc:v1 sig=4e5637f -->
 public class LdapLoginService : ILoginService
 {
    /// <summary>
@@ -50,6 +52,7 @@ public class LdapLoginService : ILoginService
    /// <param name="userService">The user service for managing user information.</param>
    /// <param name="authorityService">The authority service for managing user authorities.</param>
    /// <param name="logger">The logger for logging LDAP login operations.</param>
+    /// <!-- aidoc:v1 sig=f1b8e4e body=6c4718f -->
    public LdapLoginService(
        IOptions<LdapConfig> ldapConfig,
        IValidator<LdapConfig> validator,
@@ -82,83 +85,74 @@ public class LdapLoginService : ILoginService
    /// <returns>The authenticated user.</returns>
    /// <exception cref="LoginServicesException">Thrown when there is an error during the login process.</exception>
    /// <exception cref="UserNotFoundException">Thrown when the user is not found in the LDAP directory.</exception>
+    /// <!-- aidoc:v1 sig=bdfb451 body=e3fc1ac -->
    public async Task<User> Login(string username, string password)
    {
-        // Check for LDAP config
-        if (_ldapConfig.Server == null) throw new LoginServicesException("LDAP Config not found");
-        var conn = new LdapConnection();
+        if (_ldapConfig.Server == null)
+            throw new LoginServicesException("LDAP Config not found");
+
+        var identifier = new LdapDirectoryIdentifier(_ldapConfig.Server, _ldapConfig.Port ?? 389);
+        var connection = new LdapConnection(identifier);
+
        try
        {
-            await conn.ConnectAsync(_ldapConfig.Server, _ldapConfig.Port ?? 389);
-        }
-        catch (Exception e)
-        {
-            _logger.LogError("[LDAP] Error connecting to {server}, port {port}, Exception: {e}", _ldapConfig.Server,
-                _ldapConfig.Port, e.Message);
-            throw;
-        }
-
-        if (_ldapConfig.LdapUser != null)
-        {
-            _logger.LogInformation("[LDAP] _ldapConfig.LdapUser is enabled with {LdapUser}", _ldapConfig.LdapUser);
-            await conn.BindAsync(_ldapConfig.LdapUser, _ldapConfig.LdapPassword);
-        }
-        else
-        {
-            var ldapUser = (!string.IsNullOrEmpty(_ldapConfig.UserDomainName)
-                ? _ldapConfig.UserDomainName + @"\"
-                : "") + username;
-
-            try
+            if (_ldapConfig.LdapUser != null)
            {
-                await conn.BindAsync(ldapUser, password);
+                _logger.LogInformation("[LDAP] Using configured LDAP user {LdapUser}", _ldapConfig.LdapUser);
+                connection.Credential = new NetworkCredential(_ldapConfig.LdapUser, _ldapConfig.LdapPassword);
            }
-            catch (LdapException e)
+            else
            {
-                _logger.LogError("[LDAP] Error binding ldapUser: {LdapUser} and password", ldapUser);
+                var ldapUser = (!string.IsNullOrEmpty(_ldapConfig.UserDomainName)
+                    ? _ldapConfig.UserDomainName + @"\"
+                    : "") + username;

-                throw new UserNotFoundException(username, e);
-            }
-        }
-
-        var results = await conn.SearchAsync(
-            _ldapConfig.SearchBase,
-            LdapConnection.ScopeSub,
-            $"({_ldapConfig.UserNameProperty}={username})",
-            null,
-            false);
-
-
-        LdapEntry? entry = null;
-
-        while (await results.HasMoreAsync())
-        {
-            LdapEntry? current = null;
-
-            try
-            {
-                current = await results.NextAsync();
-            }
-            catch (LdapException ex)
-            {
-                _logger.LogWarning("[LDAP] Skipping invalid entry: {error}", ex.Message);
-                continue;
+                connection.Credential = new NetworkCredential(ldapUser, password);
            }

-            if (current != null)
+            connection.AuthType = AuthType.Basic;
+            connection.Bind();
+        }
+        catch (LdapException e)
+        {
+            _logger.LogError("[LDAP] Error binding user {username}", username);
+            throw new UserNotFoundException(username, e);
+        }
+
+        SearchResultEntry? entry = null;
+
+        try
+        {
+            var request = new SearchRequest(
+                _ldapConfig.SearchBase,
+                $"({_ldapConfig.UserNameProperty}={username})",
+                SearchScope.Subtree
+            );
+
+            var response = (SearchResponse)connection.SendRequest(request);
+
+            foreach (SearchResultEntry current in response.Entries)
            {
                entry = current;
                break;
            }
        }
+        catch (Exception e)
+        {
+            _logger.LogError("[LDAP] Search error for user {username}: {error}", username, e.Message);
+            throw;
+        }

+        if (entry == null)
+            throw new LoginServicesException("LDAP User not found");

-        if (entry == null) throw new LoginServicesException("LDAP User not found");
        var userEntryLdap = GetUser(entry);
        var user = await GetOrCreateUser(userEntryLdap, entry);
-        _logger.LogInformation("[LDAP] entry is {entry} and user {user}", entry, user);
-        // user.Authorization.AddRange(GetAuthorities(entry));
-        conn.Disconnect();
+
+        _logger.LogInformation("[LDAP] entry found and user {user}", user);
+
+        connection.Dispose();
+
        return user ?? throw new LoginServicesException("LDAP User not found");
    }

@@ -168,10 +162,9 @@ public class LdapLoginService : ILoginService
    /// <param name="context">The HTTP context of the request.</param>
    /// <returns>A task representing the asynchronous operation.</returns>
    /// <exception cref="LoginServicesException">Thrown when the method is not implemented.</exception>
+    /// <!-- aidoc:v1 sig=851dc90 -->
    public Task<User> Login(HttpContext context)
-    {
-        throw new LoginServicesException("Not implemented");
-    }
+        => throw new LoginServicesException("Not implemented");

    /// <summary>
    /// This method is not implemented in the LdapLoginService, as the authentication process is handled through the Login(string username, string password) method.
@@ -180,10 +173,9 @@ public class LdapLoginService : ILoginService
    /// <param name="password">The password of the user to authenticate.</param>
    /// <returns>A task representing the asynchronous operation.</returns>
    /// <exception cref="LoginServicesException">Thrown when the method is not implemented.</exception>
+    /// <!-- aidoc:v1 sig=a0b1f46 -->
    public Task<User> Authenticate(string username, string password)
-    {
-        throw new LoginServicesException("Not implemented");
-    }
+        => throw new LoginServicesException("Not implemented");

    /// <summary>
    /// This method is not implemented in the LdapLoginService, as the user retrieval process is handled through the Login(string username, string password) method and the GetOrCreateUser(User userEntryLdap, LdapEntry entry) method.
@@ -191,10 +183,9 @@ public class LdapLoginService : ILoginService
    /// <param name="id">The ID of the user to retrieve.</param>
    /// <returns>A task representing the asynchronous operation.</returns>
    /// <exception cref="LoginServicesException">Thrown when the method is not implemented.</exception>
+    /// <!-- aidoc:v1 sig=877a869 -->
    public Task<User?> GetById(ObjectId id)
-    {
-        throw new LoginServicesException("Not implemented");
-    }
+        => throw new LoginServicesException("Not implemented");

    /// <summary>
    /// This method is not implemented in the LdapLoginService, as the user retrieval process is handled through the Login(string username, string password) method and the GetOrCreateUser(User userEntryLdap, LdapEntry entry) method.
@@ -202,31 +193,29 @@ public class LdapLoginService : ILoginService
    /// <param name="email">The email of the user to retrieve.</param>
    /// <returns>A task representing the asynchronous operation.</returns>
    /// <exception cref="LoginServicesException">Thrown when the method is not implemented.</exception>
+    /// <!-- aidoc:v1 sig=ba92b09 -->
    public Task<User?> GetByEmail(string email)
-    {
-        throw new LoginServicesException("Not implemented");
-    }
+        => throw new LoginServicesException("Not implemented");

    /// <summary>
-    /// This method is not implemented in the LdapLoginService, as the user retrieval process is handled through the Login(string username, string password) method and the GetOrCreateUser(User userEntryLdap, LdapEntry entry) method.
+    /// Retrieves a <see cref="User"/> matching the specified <paramref name="username"/>.
    /// </summary>
-    /// <param name="username">The username of the user to retrieve.</param>
-    /// <returns>A task representing the asynchronous operation.</returns>
-    /// <exception cref="LoginServicesException">Thrown when the method is not implemented.</exception>
+    /// <param name="username">The username to look up.</param>
+    /// <returns>A <see cref="Task{TResult}"/> that resolves to the <see cref="User"/> if found, or <see langword="null"/> when no matching user exists.</returns>
+    /// <exception cref="LoginServicesException">Thrown because the operation is not yet implemented.</exception>
+    /// <!-- aidoc:v1 sig=5184c30 -->
    public Task<User?> GetByUsername(string username)
-    {
-        throw new LoginServicesException("Not implemented");
-    }
+        => throw new LoginServicesException("Not implemented");

    /// <summary>
-    /// This method is not implemented in the LdapLoginService, as the user retrieval process is handled through the Login(string username, string password) method and the GetOrCreateUser(User userEntryLdap, LdapEntry entry) method.
+    /// Retrieves all <see cref="User"/> entities from the system. This method is not yet implemented and currently throws a <see cref="LoginServicesException"/> when invoked.
    /// </summary>
-    /// <returns>A task representing the asynchronous operation.</returns>
-    /// <exception cref="LoginServicesException">Thrown when the method is not implemented.</exception>
+    /// <returns>A <see cref="Task{List{User}}"/> that represents the asynchronous operation, intended to contain the full collection of <see cref="User"/> entries.</returns>
+    /// <exception cref="LoginServicesException">Thrown unconditionally because the method has not been implemented.</exception>
+    /// <!-- aidoc:v1 sig=aa066d6 -->
    public Task<List<User>> GetAllUsers()
-    {
-        throw new LoginServicesException("Not implemented");
-    }
+        => throw new LoginServicesException("Not implemented");
+

    /// <summary>
    /// This method retrieves an existing user from the application based on the information obtained from the LDAP entry, or creates a new user if one does not already exist. 
@@ -235,55 +224,53 @@ public class LdapLoginService : ILoginService
    /// <param name="userEntryLdap">The user information obtained from the LDAP entry.</param>
    /// <param name="entry">The LDAP entry containing the user's information.</param>
    /// <returns>The existing or newly created user with updated authorities.</returns>
+    /// <!-- aidoc:v1 sig=87de1c2 body=a43bebd -->
    private async Task<User?> GetOrCreateUser(User userEntryLdap, LdapEntry entry)
+
    {
        var userToReturn = (await _userService.Value.GetUserByUserName(userEntryLdap.UserName) ??
                            await _userService.Value.GetUserByName(userEntryLdap.Name)) ??
                           await _userService.Value.CreateUser(userEntryLdap);

        if (userToReturn == null) return userToReturn;
+
        userToReturn.Authorization = [];

        var authorities = await CheckAuthorities(userToReturn, entry);
-
        userToReturn.Authorization.AddRange(authorities);
-        //foreach (var authorization in userToReturn.Authorization)
-        //{
-        //    Enum.TryParse<RolesType>(authorization.Rol, out var compareRole);
-        //    if (compareRole == RolesType.Admin) userToReturn.Rol = RolesType.Admin;
-        //}
+
        return userToReturn;
    }

+
    /// <summary>
    /// This method checks the authorities of a user based on the LDAP entry and the application's configuration.
    /// </summary>
    /// <param name="user">The user whose authorities are being checked.</param>
    /// <param name="entry">The LDAP entry containing the user's information.</param>
    /// <returns>A list of updated authorities for the user.</returns>
+    /// <!-- aidoc:v1 sig=d2bafd5 body=4af15eb -->
    private async Task<List<Authorization>> CheckAuthorities(User user, LdapEntry entry)
+
    {
        try
        {
            var authorizationMap = GetAuthoritiesMap(entry, user);
            var authorizationWhiteList = GetAuthoritiesWhiteList(entry, user);
-            _logger.LogInformation(
-                "[LDAP] user {user} authorizationMap count is {authorizationMap}, authorizationWhiteList count is {authorizationWhiteList}",
-                user.UserName, authorizationMap.Count, authorizationWhiteList.Count);

-            // Primero, creamos un HashSet con los DisplayID de la lista blanca para búsqueda eficiente
            var whiteListDisplayIds = new HashSet<string?>(authorizationWhiteList.Select(a => a.DisplayId));

-            // Filtramos los elementos de authorizationMap que no están en la lista blanca, basándonos en DisplayID
-            var uniqueMapAuthorizations = authorizationMap.Where(a => !whiteListDisplayIds.Contains(a.DisplayId));
+            var uniqueMapAuthorizations = authorizationMap
+                .Where(a => !whiteListDisplayIds.Contains(a.DisplayId));

-            // Finalmente, combinamos los elementos únicos de authorizationMap con los de authorizationWhiteList
            var combinedList = authorizationWhiteList.Concat(uniqueMapAuthorizations).ToList();

            var userAuthorities = await _authorityService.GetUserAuthorities(user.Id);
+
            foreach (var auth in combinedList)
            {
                var authFound = userAuthorities.Find(c => c.DisplayId == auth.DisplayId);
+
                if (authFound is { CanUpdate: true })
                {
                    authFound.Rol = auth.Rol;
@@ -299,42 +286,41 @@ public class LdapLoginService : ILoginService
        }
        catch (Exception e)
        {
-            _logger.LogError("[LDAP] CheckAuthorities for user {user} has exception {ex}", user.UserName, e.Message);
+            _logger.LogError("[LDAP] CheckAuthorities error for user {user}: {error}",
+                user.UserName, e.Message);

            return [];
        }
    }

+
    /// <summary>
    /// This method retrieves a list of authorities for a user based on a whitelist defined in the application's configuration.
    /// </summary>
    /// <param name="entry">The LDAP entry containing the user's information.</param>
    /// <param name="user">The user whose authorities are being retrieved.</param>
    /// <returns>A list of authorities for the user based on the whitelist.</returns>
+    /// <!-- aidoc:v1 sig=a8263f0 body=9e6cc38 -->
    private List<Authorization> GetAuthoritiesWhiteList(LdapEntry entry, User user)
+
    {
        try
        {
-            var userWhiteList = new List<Authorization>();
-            var userNameProperty = _ldapConfig.UserNameProperty;
+            var result = new List<Authorization>();

            var whiteList = _ldapConfig.WhiteList.FindAll(u =>
-                (u.Name != null && entry.Dn.Contains(u.Name, StringComparison.CurrentCultureIgnoreCase)) ||
+                (u.Name != null && entry.DistinguishedName.Contains(u.Name, StringComparison.CurrentCultureIgnoreCase)) ||
                (u.Username != null &&
-                 userNameProperty != null &&
-                 entry.GetAttributeSet().TryGetValue(userNameProperty, out var attr) &&
-                 attr.StringValue != null &&
-                 attr.StringValue.Equals(u.Username, StringComparison.CurrentCultureIgnoreCase))
+                 entry.Attributes[_ldapConfig.UserNameProperty]?[0]?.ToString()
+                     ?.Equals(u.Username, StringComparison.CurrentCultureIgnoreCase) == true)
            );

-            if (whiteList.Count == 0) return userWhiteList;
-
            foreach (var authorityMap in whiteList)
            {
                if (!Enum.TryParse<PermissionEnum.RolesType>(authorityMap.Rol, out _))
                    continue;

-                userWhiteList.Add(new Authorization
+                result.Add(new Authorization
                {
                    UserId = user.Id,
                    DisplayId = authorityMap.DisplayId,
@@ -342,70 +328,59 @@ public class LdapLoginService : ILoginService
                });
            }

-            return userWhiteList;
+            return result;
        }
        catch (Exception e)
        {
-            _logger.LogError("[LDAP] GetAuthoritiesWhiteList for user {user} has exception {ex}", user.UserName,
-                e.Message);
-
+            _logger.LogError("[LDAP] GetAuthoritiesWhiteList error: {error}", e.Message);
            return [];
        }
    }

+
    /// <summary>
-    /// This method retrieves a list of authorities for a user based on the LDAP entry and the application's configuration for mapping LDAP groups to authorities.
+    /// Maps an <see cref="LdapEntry"/> to a <see cref="User"/> object, populating the username from the configured attribute and, when the corresponding properties are configured, composing the user's name from the first and last name attributes.
    /// </summary>
-    /// <param name="ldapEntry">The LDAP entry containing the user's information.</param>
-    /// <returns>The existing or newly created user with updated authorities.</returns>
+    /// <param name="ldapEntry">The <see cref="LdapEntry"/> from which the <see cref="User"/> properties are read.</param>
+    /// <returns>A <see cref="User"/> instance populated from the LDAP entry attributes.</returns>
+    /// <!-- aidoc:v1 sig=947181a body=33ffec8 -->
    private User GetUser(LdapEntry ldapEntry)
+
    {
-        var attributes = ldapEntry.GetAttributeSet();
-
-        var user = new User();
-
-        // UserName
-        if (!string.IsNullOrWhiteSpace(_ldapConfig.UserNameProperty) &&
-            attributes.TryGetValue(_ldapConfig.UserNameProperty, out var userAttr) &&
-            userAttr?.StringValue != null)
+        var user = new User
        {
-            user.UserName = userAttr.StringValue;
-        }
-        else
+            UserName = entry.Attributes[_ldapConfig.UserNameProperty]?[0]?.ToString() ?? ""
+        };
+
+        if (!string.IsNullOrWhiteSpace(_ldapConfig.FirstNameProperty))
        {
-            user.UserName = "";
+            var first = entry.Attributes[_ldapConfig.FirstNameProperty]?[0]?.ToString();
+            if (first != null)
+                user.Name = first;
        }

-        _logger.LogInformation("[LDAP] GetUser UserName is {UserName} ", user.UserName);
-
-        // First name
-        if (!string.IsNullOrWhiteSpace(_ldapConfig.FirstNameProperty) &&
-            attributes.TryGetValue(_ldapConfig.FirstNameProperty, out var firstNameAttr) &&
-            firstNameAttr?.StringValue != null)
+        if (!string.IsNullOrWhiteSpace(_ldapConfig.LastNameProperty))
        {
-            user.Name = firstNameAttr.StringValue;
-        }
-
-        // Last name
-        if (!string.IsNullOrWhiteSpace(_ldapConfig.LastNameProperty) &&
-            attributes.TryGetValue(_ldapConfig.LastNameProperty, out var lastNameAttr) &&
-            lastNameAttr?.StringValue != null)
-        {
-            user.Name = string.IsNullOrEmpty(user.Name)
-                ? lastNameAttr.StringValue
-                : $"{user.Name} {lastNameAttr.StringValue}";
+            var last = entry.Attributes[_ldapConfig.LastNameProperty]?[0]?.ToString();
+            if (last != null)
+                user.Name = string.IsNullOrEmpty(user.Name)
+                    ? last
+                    : $"{user.Name} {last}";
        }

        return user;
    }

+
    /// <summary>
    /// This method retrieves a list of authorities for a user based on the LDAP entry and the application's configuration for mapping LDAP groups to authorities.
    /// </summary>
    /// <param name="ldapEntry">The LDAP entry containing the user's information.</param>
    /// <param name="user">The user whose authorities are being retrieved.</param>
    /// <returns>A list of authorities for the user based on the LDAP entry and the application's configuration.</returns>
+    /// <!-- aidoc:v1 sig=1e1f0f2 body=18015c0 -->
    private List<Authorization> GetAuthoritiesMap(LdapEntry ldapEntry, User user)
+
    {
        try
        {
@@ -414,16 +389,14 @@ public class LdapLoginService : ILoginService
            if (!_ldapConfig.AuthoritiesMap.Any())
                return authorities;

-            var attributes = ldapEntry.GetAttributeSet();
+            var groupAttr = entry.Attributes[_ldapConfig.GroupsProperty];

-            if (!string.IsNullOrWhiteSpace(_ldapConfig.GroupsProperty) ||
-                !attributes.TryGetValue(_ldapConfig.GroupsProperty!, out var groupsAttr) ||
-                groupsAttr?.StringValueArray == null)
-            {
+            if (groupAttr == null)
                return authorities;
-            }

-            var groups = groupsAttr.StringValueArray.ToList();
+            var groups = groupAttr.GetValues(typeof(string))
+                .Cast<string>()
+                .ToList();

            foreach (var authorityMap in _ldapConfig.AuthoritiesMap)
            {
@@ -446,7 +419,7 @@ public class LdapLoginService : ILoginService
        }
        catch (Exception e)
        {
-            _logger.LogError("Error getting Authorities Map. Return new empty list. Exception: {e}", e);
+            _logger.LogError("[LDAP] GetAuthoritiesMap error: {error}", e.Message);
            return [];
        }
    }
@@ -14,7 +14,12 @@
    <ItemGroup>
        <PackageReference Include="AuditLogs" Version="1.0.59" />
        <PackageReference Include="FluentValidation" Version="12.1.1" />
-        <PackageReference Include="Novell.Directory.Ldap.NETStandard" Version="4.0.0" />
+        <PackageReference Include="Microsoft.AspNetCore.Http" Version="2.3.11" />
+        <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="5.3.0">
+          <PrivateAssets>all</PrivateAssets>
+          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
+        <PackageReference Include="System.DirectoryServices.Protocols" Version="10.0.9" />
    </ItemGroup>

 </Project>
@@ -8,13 +8,17 @@
    </PropertyGroup>

    <ItemGroup>
-        <ProjectReference Include="..\adas-core.Authentication\adas-core.Authentication.csproj"/>
-        <ProjectReference Include="..\adas-core.Infrastructure\adas-core.Infrastructure.csproj"/>
+        <ProjectReference Include="..\adas-core.Authentication\adas-core.Authentication.csproj" />
+        <ProjectReference Include="..\adas-core.Infrastructure\adas-core.Infrastructure.csproj" />
    </ItemGroup>

    <ItemGroup>
        <PackageReference Include="AuditLogs" Version="1.0.59" />
-        <PackageReference Include="Portable.BouncyCastle" Version="1.9.0"/>
+        <PackageReference Include="Microsoft.AspNetCore.Http" Version="2.3.11" />
+        <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="5.3.0">
+          <PrivateAssets>all</PrivateAssets>
+          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
    </ItemGroup>

 </Project>
@@ -21,14 +21,18 @@

    <ItemGroup>
        <PackageReference Include="AuditLogs" Version="1.0.59" />
+        <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="5.3.0">
+          <PrivateAssets>all</PrivateAssets>
+          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
+        <PackageReference Include="Microsoft.EntityFrameworkCore.Analyzers" Version="8.0.28" />
        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.6.0" />
-        <PackageReference Include="Microsoft.QualityTools.Testing.Fakes" Version="18.1.1" />
        <PackageReference Include="Mongo2Go" Version="4.1.0" />
        <PackageReference Include="MongoMigrations.Core" Version="4.0.15" />
        <PackageReference Include="Moq" Version="4.20.72" />
        <PackageReference Include="NUnit" Version="4.6.1" />
        <PackageReference Include="NUnit3TestAdapter" Version="6.2.0" />
-        <PackageReference Include="NUnit.Analyzers" Version="4.13.0">
+        <PackageReference Include="NUnit.Analyzers" Version="4.14.0">
            <PrivateAssets>all</PrivateAssets>
            <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
        </PackageReference>
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">

    <PropertyGroup>
        <TargetFramework>net8.0</TargetFramework>
@@ -14,6 +14,10 @@
    <ItemGroup>
        <PackageReference Include="AuditLogs" Version="1.0.59" />
        <PackageReference Include="HtmlAgilityPack" Version="1.12.4" />
+        <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="5.3.0">
+          <PrivateAssets>all</PrivateAssets>
+          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
    </ItemGroup>

 </Project>
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">

    <PropertyGroup>
        <TargetFramework>net8.0</TargetFramework>
@@ -15,11 +15,7 @@

    <ItemGroup>
        <PackageReference Include="AuditLogs" Version="1.0.59" />
-        <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.8" />
-        <PackageReference Include="Microsoft.Extensions.Hosting" Version="10.0.8" />
        <PackageReference Include="Serilog" Version="4.3.1" />
-        <PackageReference Include="SharpCompress" Version="0.49.0" />
-        <PackageReference Include="Snappier" Version="1.3.1" />
    </ItemGroup>


@@ -9,7 +9,6 @@

    <ItemGroup>
        <PackageReference Include="AuditLogs" Version="1.0.59" />
-        <PackageReference Include="Microsoft.Extensions.Hosting" Version="10.0.8" />
    </ItemGroup>

    <ItemGroup>
@@ -21,7 +21,7 @@ using adas_core.WebSocket;
 using adas_core.WebSocket.Hubs;
 using audit_logs.Extensions;
 using Microsoft.Extensions.Options;
-using Microsoft.OpenApi.Models;
+using Microsoft.OpenApi;
 using MongoDB.Bson;
 using MongoDB.Driver;
 using Newtonsoft.Json;
@@ -120,7 +120,7 @@ builder.Services.AddSwaggerGen(c =>

    c.MapType<ObjectId>(() => new OpenApiSchema
    {
-        Type = "string",
+        Type = JsonSchemaType.String,
        Format = "objectid"
    });
 });
@@ -24,15 +24,17 @@

    <ItemGroup>
        <PackageReference Include="AuditLogs" Version="1.0.59" />
-        <PackageReference Include="EasyNetQ" Version="8.1.4" />
-        <PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="8.0.8" />
-        <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Scripting" Version="5.3.0" />
-        <PackageReference Include="Microsoft.EntityFrameworkCore" Version="8.0.27" />
-        <PackageReference Include="Microsoft.IdentityModel.Protocols" Version="8.18.0" />
+        <PackageReference Include="EasyNetQ" Version="8.1.5" />
+        <PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="8.0.28" />
+        <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="5.3.0">
+          <PrivateAssets>all</PrivateAssets>
+          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
+        <PackageReference Include="Microsoft.EntityFrameworkCore.Analyzers" Version="8.0.28" />
+        <PackageReference Include="Microsoft.IdentityModel.Protocols" Version="8.19.1" />
        <PackageReference Include="MongoDB.Driver" Version="3.9.0" />
        <PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
        <PackageReference Include="prometheus-net.AspNetCore" Version="8.2.1" />
-        <PackageReference Include="Quartz" Version="3.18.1" />
        <PackageReference Include="Serilog" Version="4.3.1" />
        <PackageReference Include="Serilog.AspNetCore" Version="10.0.0" />
        <PackageReference Include="Serilog.Enrichers.Dynamic" Version="1.0.9" />
@@ -42,18 +44,13 @@
        <PackageReference Include="Serilog.Formatting.Compact" Version="3.0.0" />
        <PackageReference Include="Serilog.Sinks.Console" Version="6.1.1" />
        <PackageReference Include="Serilog.Sinks.File" Version="7.0.0" />
-        
-        <PackageReference Include="System.Diagnostics.PerformanceCounter" Version="10.0.8" />
-        <PackageReference Include="System.Management" Version="10.0.8" />
-        <PackageReference Include="System.Net.Http" Version="4.3.4" />
-        <PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" />
        <PackageReference Include="WebPush" Version="1.0.13" />
    </ItemGroup>

 	<ItemGroup>
-		<PackageReference Include="Swashbuckle.AspNetCore" Version="6.5.0" />
-		<PackageReference Include="Swashbuckle.AspNetCore.Newtonsoft" Version="6.5.0" />
-		<PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="8.0.27" />
+		<PackageReference Include="Swashbuckle.AspNetCore" Version="10.2.1" />
+		<PackageReference Include="Swashbuckle.AspNetCore.Newtonsoft" Version="10.2.1" />
+		<PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="8.0.28" />
 	</ItemGroup>
 	
    <ItemGroup>
@@ -20,7 +20,7 @@
    //"ConnectionString": "mongodb://smartuci:!H12o2020@localhost:27017/?authSource=smartuci",
    //"ConnectionString": "mongodb://admin:4q*pHca@10.0.20.78:22007",
    //"ConnectionString": "mongodb://smacsuci:2(R*aQpu2r@sumo.julianrojas.xyz:27017/?authSource=admin",
-    "DatabaseName": "adasDevNewStandard"
+    "DatabaseName": "adas"
  },
  "DatabaseConfigurationAudit": {
    "ConnectionString": "mongodb://smacsuci:2(R*aQpu2r@julianrojas.xyz:27017/?authSource=admin",
Author	SHA1	Message	Date
n8n IEC 62304 Bot	ad518abd07	docs(iec62304): [REL-1.0.2] apply curated XML doc review updates	2026-07-06 21:21:05 +02:00
n8n IEC 62304 Bot	64da453152	docs(iec62304): [REL-1.0.2] validate and curate XML doc review markers	2026-07-06 21:15:15 +02:00
jrojas	8e6bc709f3	Conflicto de fusión en adas-core.LdapLogin/LdapLoginService.cs	2026-07-06 19:33:59 +02:00
jrojas	9e2246a459	se agrego rc102	2026-07-06 19:30:28 +02:00